From 797430e9f89c339e7be9e2f3cbe0b3c4dfaebe12 Mon Sep 17 00:00:00 2001 From: lana-k Date: Wed, 17 Feb 2021 16:53:28 +0100 Subject: [PATCH] minor changes --- src/fileUtils.js | 2 -- tests/unit/fileUtils.spec.js | 25 ++++--------------------- 2 files changed, 4 insertions(+), 23 deletions(-) diff --git a/src/fileUtils.js b/src/fileUtils.js index 4eff444..179bd51 100644 --- a/src/fileUtils.js +++ b/src/fileUtils.js @@ -12,7 +12,6 @@ export default { // Clean up URL.revokeObjectURL(url) - downloader.remove() }, /** @@ -29,7 +28,6 @@ export default { uploader.addEventListener('change', () => { const file = uploader.files[0] - uploader.remove() resolve(file) }) diff --git a/tests/unit/fileUtils.spec.js b/tests/unit/fileUtils.spec.js index f2b42e0..817a2ca 100644 --- a/tests/unit/fileUtils.spec.js +++ b/tests/unit/fileUtils.spec.js @@ -3,10 +3,13 @@ import fu from '@/fileUtils.js' import sinon from 'sinon' describe('fileUtils.js', () => { + afterEach(() => { + sinon.restore() + }) + it('exportToFile (octet/stream by default)', () => { const spyAnchor = document.createElement('a') sinon.spy(spyAnchor, 'click') - sinon.spy(spyAnchor, 'remove') sinon.stub(document, 'createElement').returns(spyAnchor) sinon.spy(URL, 'createObjectURL') sinon.spy(URL, 'revokeObjectURL') @@ -26,20 +29,12 @@ describe('fileUtils.js', () => { expect(spyAnchor.download).to.equal('foo.txt') expect(spyAnchor.click.calledOnce).to.equal(true) - - expect(spyAnchor.remove.calledOnce).to.equal(true) expect(URL.revokeObjectURL.calledOnceWith(url)).to.equal(true) - - URL.revokeObjectURL.restore() - URL.createObjectURL.restore() - window.Blob.restore() - document.createElement.restore() }) it('exportToFile', () => { const spyAnchor = document.createElement('a') sinon.spy(spyAnchor, 'click') - sinon.spy(spyAnchor, 'remove') sinon.stub(document, 'createElement').returns(spyAnchor) sinon.spy(URL, 'createObjectURL') sinon.spy(URL, 'revokeObjectURL') @@ -59,20 +54,12 @@ describe('fileUtils.js', () => { expect(spyAnchor.download).to.equal('foo.html') expect(spyAnchor.click.calledOnce).to.equal(true) - - expect(spyAnchor.remove.calledOnce).to.equal(true) expect(URL.revokeObjectURL.calledOnceWith(url)).to.equal(true) - - URL.revokeObjectURL.restore() - URL.createObjectURL.restore() - window.Blob.restore() - document.createElement.restore() }) it('importFile', () => { const spyInput = document.createElement('input') sinon.spy(spyInput, 'click') - sinon.spy(spyInput, 'remove') const blob = new Blob(['foo']) Object.defineProperty(spyInput, 'files', { @@ -91,8 +78,6 @@ describe('fileUtils.js', () => { expect(spyInput.type).to.equal('file') expect(spyInput.accept).to.equal('.json') expect(spyInput.click.calledOnce).to.equal(true) - expect(spyInput.remove.calledOnce).to.equal(true) - document.createElement.restore() }) }) @@ -101,7 +86,5 @@ describe('fileUtils.js', () => { fu.readFile('./foo.bar') expect(window.fetch.calledOnceWith('./foo.bar')).to.equal(true) - - window.fetch.restore() }) })