nghttp2/nghttp2
1
0
Fork 0
mirror of https://github.com/nghttp2/nghttp2.git synced 2025-12-06 18:18:52 +08:00
Code Issues Projects Releases Wiki Activity

lib: since hd_inflate_commit_indexed() always return 0, remove the

Browse Source 
return value check in nghttp2_hd_inflate_hd_nv().
This commit is contained in:
Wenfeng Liu
2016-08-11 02:00:43 +00:00
parent 2d8059a9a5
commit 65cc2f0515
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/nghttp2_hd.c
View File

@@ -1677,15 +1677,8 @@ static ssize_t hd_inflate_read(nghttp2_hd_inflater *inflater, nghttp2_buf *buf,
} }
/* /*
* Finalize indexed header representation reception. If header is * Finalize indexed header representation reception. header is always
* emitted, |*nv_out| is filled with that value and 0 is returned. If * emitted, |*nv_out| is filled with that value and 0 is returned.
* no header is emitted, 1 is returned.
*
* This function returns either 0 or 1 if it succeeds, or one of the
* following negative error codes:
*
* NGHTTP2_ERR_NOMEM
* Out of memory
*/ */
static int hd_inflate_commit_indexed(nghttp2_hd_inflater *inflater, static int hd_inflate_commit_indexed(nghttp2_hd_inflater *inflater,
nghttp2_hd_nv *nv_out) { nghttp2_hd_nv *nv_out) {
@@ -1944,16 +1937,11 @@ ssize_t nghttp2_hd_inflate_hd_nv(nghttp2_hd_inflater *inflater,
inflater->index = inflater->left; inflater->index = inflater->left;
--inflater->index; --inflater->index;
rv = hd_inflate_commit_indexed(inflater, nv_out); hd_inflate_commit_indexed(inflater, nv_out);
if (rv < 0) {
goto fail;
}
inflater->state = NGHTTP2_HD_STATE_OPCODE; inflater->state = NGHTTP2_HD_STATE_OPCODE;
/* If rv == 1, no header was emitted */
if (rv == 0) {
*inflate_flags |= NGHTTP2_HD_INFLATE_EMIT; *inflate_flags |= NGHTTP2_HD_INFLATE_EMIT;
return (ssize_t)(in - first); return (ssize_t)(in - first);
}
} else { } else {
inflater->index = inflater->left; inflater->index = inflater->left;
--inflater->index; --inflater->index;