nghttp2/nghttp2
1
0
Fork 0
mirror of https://github.com/nghttp2/nghttp2.git synced 2025-12-10 03:58:53 +08:00
Code Issues Projects Releases Wiki Activity

Ignore unknown frame types

Browse Source 
Unexpected CONTINUATION frame is handled separately as connection
error.
This commit is contained in:
Tatsuhiro Tsujikawa
2014-06-07 16:30:55 +09:00
parent 3db8935e20
commit 458ccb3681
4 changed files with 100 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

76
tests/nghttp2_session_test.c
View File

@@ -1146,6 +1146,82 @@ void test_nghttp2_session_recv_altsvc(void)
nghttp2_session_del(session);
}
void test_nghttp2_session_recv_unknown_frame(void)
{
nghttp2_session *session;
nghttp2_session_callbacks callbacks;
my_user_data ud;
uint8_t data[16384];
size_t datalen;
nghttp2_frame_hd hd;
ssize_t rv;
hd.length = 16000;
hd.stream_id = 0;
hd.type = 99;
hd.flags = NGHTTP2_FLAG_NONE;
nghttp2_frame_pack_frame_hd(data, &hd);
datalen = NGHTTP2_FRAME_HDLEN + hd.length;
memset(&callbacks, 0, sizeof(nghttp2_session_callbacks));
callbacks.on_frame_recv_callback = on_frame_recv_callback;
nghttp2_session_server_new(&session, &callbacks, &ud);
ud.frame_recv_cb_called = 0;
/* Unknown frame must be ignored */
rv = nghttp2_session_mem_recv(session, data, datalen);
CU_ASSERT(rv == (ssize_t)datalen);
CU_ASSERT(0 == ud.frame_recv_cb_called);
CU_ASSERT(NULL == nghttp2_session_get_next_ob_item(session));
nghttp2_session_del(session);
}
void test_nghttp2_session_recv_unexpected_continuation(void)
{
nghttp2_session *session;
nghttp2_session_callbacks callbacks;
my_user_data ud;
uint8_t data[16384];
size_t datalen;
nghttp2_frame_hd hd;
ssize_t rv;
nghttp2_outbound_item *item;
hd.length = 16000;
hd.stream_id = 1;
hd.type = NGHTTP2_CONTINUATION;
hd.flags = NGHTTP2_FLAG_END_HEADERS;
nghttp2_frame_pack_frame_hd(data, &hd);
datalen = NGHTTP2_FRAME_HDLEN + hd.length;
memset(&callbacks, 0, sizeof(nghttp2_session_callbacks));
callbacks.on_frame_recv_callback = on_frame_recv_callback;
nghttp2_session_server_new(&session, &callbacks, &ud);
open_stream(session, 1);
ud.frame_recv_cb_called = 0;
/* unexpected CONTINUATION must be treated as connection error */
rv = nghttp2_session_mem_recv(session, data, datalen);
CU_ASSERT(rv == (ssize_t)datalen);
CU_ASSERT(0 == ud.frame_recv_cb_called);
item = nghttp2_session_get_next_ob_item(session);
CU_ASSERT(NGHTTP2_GOAWAY == OB_CTRL_TYPE(item));
nghttp2_session_del(session);
}
void test_nghttp2_session_continue(void)
{
nghttp2_session *session;